Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump to ruff 0.9 and mypy 1.14 #909

Merged
merged 7 commits into from
Jan 15, 2025
Merged

chore: bump to ruff 0.9 and mypy 1.14 #909

merged 7 commits into from
Jan 15, 2025

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Jan 9, 2025

2025 style.

@henryiii
chore: bump to ruff 0.9 and mypy 1.14
fdec87d 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
fix: use consistent -r and fix editable test
a69e89e 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
DiddiLeija
DiddiLeija reviewed Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Though I found a small mistake :)

tests/test_tox_to_nox.py Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
henryiii and others added 2 commits January 13, 2025 14:51
@henryiii @DiddiLeija
Apply suggestions from code review
9967bd5 
Co-authored-by: Diego Ramirez <dr01191115@gmail.com>
@henryiii
tests: ignore -r seperation
91abf2b 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
Copy link
Collaborator Author

henryiii commented Jan 13, 2025 •
edited
Loading

How do we feel about dropping support for tox 3? :) AFAICT, the tox 4 implementation is independent of tox, so it should "just work" even if tox is not installed. Nevermind, it does depend on tox config, which should probably still work, but probably not worth testing.

henryiii
henryiii commented Jan 15, 2025
View reviewed changes
tests/test_tox_to_nox.py Outdated Show resolved Hide resolved
henryiii
henryiii commented Jan 15, 2025
View reviewed changes
tests/test_tox_to_nox.py Outdated Show resolved Hide resolved
@henryiii henryiii merged commit c27bff9 into wntrblm:main Jan 15, 2025
24 checks passed
@henryiii henryiii deleted the henryiii/chore/ruff0.9 branch January 15, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiddiLeija DiddiLeija DiddiLeija left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henryiii @DiddiLeija