Don't run python 2.7 virtualenv tests for newer versions of virtualenv #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it's still sad about coverage :-( |
alex
approved these changes
Apr 22, 2023
stefanor
reviewed
May 8, 2023
|
|
||
| import nox.virtualenv | ||
|
|
||
| IS_WINDOWS = nox.virtualenv._SYSTEM == "Windows" | ||
| HAS_CONDA = shutil.which("conda") is not None | ||
| RAISE_ERROR = "RAISE_ERROR" | ||
| VIRTUALENV_VERSION = virtualenv.version.version |
There was a problem hiding this comment.
That's only available in recent versions of virtualenv, using hatch-vcs.
A quick dig didn't show me exactly what made it change, but in older versions, the path was: virtualenv.__version__ (which is still available today)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #701
Newer virtualenv versions have dropped py2.7 support.