Skip to content

Commit

Permalink
Update type annotation of stderr parameter to make it optional (#835)
Browse files Browse the repository at this point in the history
  • Loading branch information
edgarrmondragon authored Jun 27, 2024
1 parent cf82e6d commit 4fb39b6
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion nox/command.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def run(
log: bool = True,
external: ExternalType = False,
stdout: int | IO[str] | None = None,
stderr: int | IO[str] = subprocess.STDOUT,
stderr: int | IO[str] | None = subprocess.STDOUT,
interrupt_timeout: float | None = DEFAULT_INTERRUPT_TIMEOUT,
terminate_timeout: float | None = DEFAULT_TERMINATE_TIMEOUT,
) -> str | bool:
Expand Down
2 changes: 1 addition & 1 deletion nox/popen.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def popen(
env: Mapping[str, str] | None = None,
silent: bool = False,
stdout: int | IO[str] | None = None,
stderr: int | IO[str] = subprocess.STDOUT,
stderr: int | IO[str] | None = subprocess.STDOUT,
interrupt_timeout: float | None = DEFAULT_INTERRUPT_TIMEOUT,
terminate_timeout: float | None = DEFAULT_TERMINATE_TIMEOUT,
) -> tuple[int, str]:
Expand Down
12 changes: 6 additions & 6 deletions nox/sessions.py
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ def run(
log: bool = True,
external: ExternalType | None = None,
stdout: int | IO[str] | None = None,
stderr: int | IO[str] = subprocess.STDOUT,
stderr: int | IO[str] | None = subprocess.STDOUT,
interrupt_timeout: float | None = DEFAULT_INTERRUPT_TIMEOUT,
terminate_timeout: float | None = DEFAULT_TERMINATE_TIMEOUT,
) -> Any | None:
Expand Down Expand Up @@ -433,7 +433,7 @@ def run_install(
log: bool = True,
external: ExternalType | None = None,
stdout: int | IO[str] | None = None,
stderr: int | IO[str] = subprocess.STDOUT,
stderr: int | IO[str] | None = subprocess.STDOUT,
interrupt_timeout: float | None = DEFAULT_INTERRUPT_TIMEOUT,
terminate_timeout: float | None = DEFAULT_TERMINATE_TIMEOUT,
) -> Any | None:
Expand Down Expand Up @@ -515,7 +515,7 @@ def run_always(
log: bool = True,
external: ExternalType | None = None,
stdout: int | IO[str] | None = None,
stderr: int | IO[str] = subprocess.STDOUT,
stderr: int | IO[str] | None = subprocess.STDOUT,
interrupt_timeout: float | None = DEFAULT_INTERRUPT_TIMEOUT,
terminate_timeout: float | None = DEFAULT_TERMINATE_TIMEOUT,
) -> Any | None:
Expand Down Expand Up @@ -548,7 +548,7 @@ def _run(
log: bool,
external: ExternalType | None,
stdout: int | IO[str] | None,
stderr: int | IO[str],
stderr: int | IO[str] | None,
interrupt_timeout: float | None,
terminate_timeout: float | None,
) -> Any:
Expand Down Expand Up @@ -611,7 +611,7 @@ def conda_install(
success_codes: Iterable[int] | None = None,
log: bool = True,
stdout: int | IO[str] | None = None,
stderr: int | IO[str] = subprocess.STDOUT,
stderr: int | IO[str] | None = subprocess.STDOUT,
interrupt_timeout: float | None = DEFAULT_INTERRUPT_TIMEOUT,
terminate_timeout: float | None = DEFAULT_TERMINATE_TIMEOUT,
) -> None:
Expand Down Expand Up @@ -718,7 +718,7 @@ def install(
log: bool = True,
external: ExternalType | None = None,
stdout: int | IO[str] | None = None,
stderr: int | IO[str] = subprocess.STDOUT,
stderr: int | IO[str] | None = subprocess.STDOUT,
interrupt_timeout: float | None = DEFAULT_INTERRUPT_TIMEOUT,
terminate_timeout: float | None = DEFAULT_TERMINATE_TIMEOUT,
) -> None:
Expand Down

0 comments on commit 4fb39b6

Please sign in to comment.