-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More IR remotes (24/40/44-keys) and select them in the settings #569
Conversation
added more IR remotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments based on the failed automated build check.
#define COLOR_WARMWHITE2 0xFFAA69 | ||
#define COLOR_WARMWHITE 0xFFBF8E | ||
#define COLOR_NEUTRALWHITE 0xFFD4B4 | ||
#define COLOR_COLDWHITE 0xFFE9D9 | ||
#define COLOR_COLDWHITE2 0xFFFFFF | ||
#define COLOR2_WARMWHITE2 0xFFFF9900 | ||
#define COLOR2_WARMWHITE 0xFF825A00 | ||
#define COLOR2_NEUTRALWHITE 0xFF000000 | ||
#define COLOR2_COLDWHITE 0xFF7F7F7F | ||
#define COLOR2_COLDWHITE2 0xFFFFFFFF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more colors - the ones that begin with "COLOR2_" are 32 bit / RGBW - the other ones 24 bit / RGB.
@@ -160,7 +157,7 @@ bool syncToggleReceive = false; //UIs which only have a single but | |||
|
|||
//Sync CONFIG | |||
bool buttonEnabled = true; | |||
bool irEnabled = false; //Infrared receiver | |||
byte irEnabled = 0; //Infrared receiver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this changes the "ON/OFF" checkbox to a value entry field (0 to 4) with 0=disabled, 1=1st remote, 2=2nd remote etc. /// 4 different IR remotes in total.
} | ||
|
||
|
||
void initIR() | ||
{ | ||
if (irEnabled) | ||
if (irEnabled > 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed fronm bool to integer
@@ -126,10 +328,10 @@ void initIR() | |||
|
|||
void handleIR() | |||
{ | |||
if (irEnabled && millis() - irCheckedTime > 120) | |||
if (irEnabled > 0 && millis() - irCheckedTime > 120) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed fronm bool to integer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments to explain what I did ... 😄
from '|' to '||'
Thanks, this is awesome! Yes, of course, feel free to add the remotes to the Infrared wiki page :) |
Thanks you #Def3nder for this awesome addition I have 2 different remotes and now I can use both without any modifications of the code ! Thanks |
I have the 44 key IR with only one button for on/off, the same as shown above. I am only able to turn the circuit on, but not off. |
The same problem I have with the 44 key remote. |
On my remote, the code 0xff02fd is used for both on and off. I defined IRCUSTOM_ONOFF to get it to work correctly. Maybe you should add an additonal remote with a toggle code. |
Hi @Aircoookie ,
I added the logic for three more IR remotes that can be bought for small money at AliExpress (less than 2 EUR) and changed the settings so that the actual remote type can be selected instead of just turning all ON/OFF.
If you like I can add pictures of the remotes and a link to AliExpress to the wiki:
24-key:

40-key:

44-key:
