Introduce printSetInputMaxlength to properly set an inputs maxlength … #4296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to !4295 by fixing MQTT related code that deals with the
MQTT_MAX_TOPIC_LEN
variable.Previously, the

maxlength
attribute on the<input>
fields insettings_sync.html
were set withinputElement.maxlength = <length>
, however this did not seem to actually modify themaxlength
attribute as seen in the screenshot (also I couldn't type any more characters than the previous maxlength setting):As seen, modifying
element.maxlength
does actually modify the variable, but it does not modify themaxlength
attribute weirdly. Usingelement.setAttribute("maxlength", X)
was the fix.In this PR I've modified the code to implement a function to use this JS line instead of the one previously used.