Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make palette editor more mobile friendly #3617

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Conversation

imeszaros
Copy link
Contributor

  • adjusts the page layout to eliminate scrolling on mobile screens
  • makes it possible to drag the color markers on the palette editor on mobile browsers

@blazoncek
Copy link
Collaborator

Thanks. When time permits I'll test and comment.

@ljmerza
Copy link

ljmerza commented Dec 29, 2023

are you able to post a small gif of how the interaction has imporved?

@imeszaros
Copy link
Contributor Author

imeszaros commented Dec 30, 2023

are you able to post a small gif of how the interaction has imporved?

Sure, here's the original behavior:
https://i.postimg.cc/3xsSc68J/cpal-orig.gif

And here's the fixed behavior:
https://i.postimg.cc/HLT5n439/cpal-fixed.gif

@blazoncek blazoncek merged commit e8b3c66 into wled:main Dec 30, 2023
12 checks passed
softhack007 pushed a commit to MoonModules/WLED-MM that referenced this pull request Jan 2, 2024
Make palette editor more mobile friendly
Djelibeybi pushed a commit to Djelibeybi/WLED-MM that referenced this pull request Jan 15, 2024
Make palette editor more mobile friendly
@imeszaros imeszaros deleted the cpal-mobile branch January 20, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants