Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WifiStatus usermod - indicate Wifi state with LED blinks #3574

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

petrusvr
Copy link

@petrusvr petrusvr commented Dec 7, 2023

New User mode v2 added. Wifi status user mode indicates Wifi state with different blink types on LED connected to configured PIN.

@blazoncek
Copy link
Collaborator

Thank you.
You could also modify or enhance STATUSLED functionality within WLED core.

@petrusvr
Copy link
Author

petrusvr commented Dec 9, 2023

Thank you. You could also modify or enhance STATUSLED functionality within WLED core.

Oh, I haven't notice that functionality. But using WifiStatus usermod gives possibility to configure pins/enabled from UI. So, maybe it is not worthless.

@blazoncek
Copy link
Collaborator

I am not very fond of duplicate code 🤷‍♂️ but otherwise have no objections.

@blazoncek
Copy link
Collaborator

Please update PR and rebase to 0_14_2 branch.

@blazoncek
Copy link
Collaborator

Similar to #3631

@dosipod
Copy link
Contributor

dosipod commented Jan 23, 2024

@petrusvr
I tried the usermod and it works as expected , one thing i am curious about since you are making a usermod
is to have the ability to use something like ws2812b pixel for status leds and might be add colors

In the current wled.cpp code the logic does not seem to work as expected and the onboard led will blink all the time even when wled is connected to wifi which does not make sense , only worked for me when i changed the logic and also could not get it to work with normal pixel just the onboard led , did you notice the same behavior when just using the -D STATUSLED=2
Seems too important feature in this hard times of multiple reports of connectivity issues and i also think it should be core functionality
image

@softhack007 softhack007 added discussion rebase needed This PR needs to be re-based to the current development branch labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement rebase needed This PR needs to be re-based to the current development branch usermod usermod related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants