Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pakistan timezone #2840

Closed
wants to merge 7 commits into from
Closed

Add Pakistan timezone #2840

wants to merge 7 commits into from

Conversation

yousaf465
Copy link

Added Pakistan Standard Timezone

Aircoookie and others added 7 commits August 21, 2022 12:50
@Aircoookie Aircoookie changed the base branch from main to 0_14 October 19, 2022 09:02
@blazoncek
Copy link
Collaborator

You should use 0_14 branch as your base for this PR.
And then make PR for 0_14 branch, not main. Aircoookie already changed that but there are other issues involved.

Aircoookie added a commit that referenced this pull request Oct 19, 2022
@Aircoookie
Add PKT timezone (see PR #2840)
5c542d6
@blazoncek blazoncek changed the title Update ntp.cpp Add Pakistan timezone Oct 19, 2022
@Aircoookie
Copy link
Member

Rebasing caused a merge conflict, I've added the new timezone manually. Thank you for the contribution!

@Aircoookie Aircoookie closed this Oct 19, 2022
@yousaf465
Copy link
Author

Rebasing caused a merge conflict, I've added the new timezone manually. Thank you for the contribution!

Now new builds have Pakistani time zone? @blazoncek including yours and serg74's ?

@Aircoookie
Copy link
Member

Yes, all new 0.14 builds from now on will.

softhack007 added a commit to atuline/WLED that referenced this pull request Oct 20, 2022
@softhack007
some bugfixes from upstream 0.14.0
07efa88 
- issue wled#2820 AEST Time Is Incorrect
- PR wled#2840 Add PKT time zone
- issue wled#2708 4LD unnecessary use of software I2C on ESP32
@softhack007
Copy link
Collaborator

Now new builds have Pakistani time zone? @blazoncek including yours and serg74's ?

Even more than that. I've also back-ported the change into our Soundreactive fork v0.13.3 - currently in beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yousaf465 @blazoncek @Aircoookie @softhack007 @sorensd @paeppi88 @Renaud11232