This repository has been archived by the owner on Mar 16, 2019. It is now read-only.
Share cookies with RN, remove cookie utils #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jacse , thanks for the PR, great job 👍 |
Jacse
commented
Jun 6, 2017
| @@ -196,7 +194,7 @@ else if(this.options.fileCache) | |||
| if (this.options.trusty) { | |||
| clientBuilder = RNFetchBlobUtils.getUnsafeOkHttpClient(); | |||
There was a problem hiding this comment.
This line should have been clientBuilder = RNFetchBlobUtils.getUnsafeOkHttpClient(client); so it can build on top of the react-native client. I must have forgotten to change it. @wkh237 could you change it on master or should I submit a new PR?
wkh237
added a commit
that referenced
this pull request
Jun 6, 2017
|
Thanks for merging @wkh237. Wiki should be updated as well. |
|
Can we please get an example of how to use |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope I am creating this PR the right place, as I couldn't find the branches mentioned.
This is a PR to address issues #156, #157, #220. It makes the android version share cookies with react native (regular
fetchshares cookies withRNFetchBlob) as it already seems to do on iOS, so the PR harmonises the behaviour on the platforms.Now that both platforms share cookies with react native, I though a very sensible move would be to remove this library's cookie-CRUD capabilities, as all use cases now can be solved by using other libraries such as
react-native-cookies. This frees us from spending time on problems that are better solved elsewhere and focus on the main issue the library is meant to solve. It also minimises bloat as only a fraction of users will actually need to use cookie CRUD-features.I makes even more sense considering CRUD isn't really working in this library. So I say: Let others do the cookie-manipulation and lets just share cookies with react-native. It will take away a lot of confusion and pain from users (especially when the two platforms behave differently!).
I'm not too sharp in Objective-C (or Java for that matter) so some testing will need to be done.