Function dispatcher optimization #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit simplifies and optimizes the performance-critical function dispatch loop (both simple + complex variants). Besides dispatching calls, this loop code previously did a few additional things that are now all moved to other places: - Ensuring that an already initialized class cannot be initialized again. The class type caster now checks for this. - Ensuring sure that ``super().function()`` within a trampoline reaches the parent class implementation of ``function()``, which required tracking some TLS state. This functionality is now moved to the trampolines. - Double-checking that the 'self' type in a constructor is actually a class bound via nanobind. nanobind now verifies that this is the case when the binding is first created. - Besides function dispatcher tweaks, there is also a small improvement related to trampolines: dispatching a function call to Python now acquires/releases the GIL only a single time instead of twice. - The commit adds a bit to ``nb_inst`` and hence bumps the ABI version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit simplifies and optimizes the performance-critical function dispatch loop (both simple + complex variants).
Besides dispatching calls, this loop code previously did a few additional things that are now all moved to other places:
Ensuring that an already initialized class cannot be initialized again. The class type caster now checks for this.
Ensuring sure that
super().function()within a trampoline reaches the parent class implementation offunction(), which required tracking some TLS state. This functionality moved to the trampoline-specific implementation innb_trampoline.cpp/trampoline.h.Double-checking that the 'self' type in a constructor is actually a class bound via nanobind. nanobind now verifies that this is the case when the binding is first created.
Besides function dispatcher tweaks, there is also a small improvement related to trampolines: dispatching a function call to Python now acquires/releases the GIL only a single time instead of twice.
The commit adds a bit to
nb_instand hence bumps the ABI version.