Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jellyfin library access for new users #198

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

EthanArmbrust
Copy link
Contributor

Fixes #101

Copy link

@realashleybailey realashleybailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have approved this as it looks okay and works, is it possible if you could explain your process as to why you believe this change fixes the bug so we can have a record for it when we come around to rewriting this code for Wizarr V3

@realashleybailey realashleybailey merged commit b53b2b9 into wizarrrr:master Aug 5, 2023
@EthanArmbrust
Copy link
Contributor Author

I put a little comment explaining it in the review. I've tested it my personal jellyfin server to confirm that it works.

@realashleybailey

This comment was marked as abuse.

@EthanArmbrust
Copy link
Contributor Author

EthanArmbrust commented Aug 5, 2023

My review shows as pending so I'll put it here too.

https://github.com/Wizarrrr/wizarr/blob/771c3f128959da497867ef9888ff3513579a860d/app/jellyfin.py#L66
This line overwrites the two existing values that we want in policy with the jellyfin defaults from the GET response. We need to update the response's dict with our policy , not update our policy with Jellyfin's response. Then we can post the updated policy.

@realashleybailey

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Jellyfin invitations do not restrict access to library
2 participants