Breaking: change API to be a real subset of Node's #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exists is still broken
node doesn't provide one
better compat with node's types, allowing promisified node API to be accepted as-is
- APi is now compat with node's. Promise-based API is available on "promises" field. - add missing readlink
until links are supported. native node fn throws for every non-link.
uses node as-is. adds several things
idoros
pushed a commit
to idoros/file-services
that referenced
this pull request
May 1, 2019
- Drop node 8 support. - Exposes all promise-based API under `promises` field (matches Node 10+). - Node package uses Node 10's native `promises` API instead of promisifying them every time via `proper-fs`. - Callback-style API is now exposed as well from async file systems. - `readlink` (promise and callback style) and `readlinkSync` is now exposed as well, for better compatibility with libraries expecting Node-style API. closes wixplosives#14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
promisesfield (matches Node 10+).promisesAPI instead of promisifying them every time viaproper-fs.readlink(promise and callback style) andreadlinkSyncis now exposed as well, for better compatibility with libraries expecting Node-style API.closes #14