fix(core): scope nested global selector issues #2925
Merged
+42
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- properly scope global rules nested in st-scope atrule - align js/css mixin behavior of adding the
idoros
commented
Nov 20, 2023
| // merge scope flags | ||
| const nestStartWithNesting = first.type === `nesting`; | ||
| const nestedStartWithGlobal = | ||
| rootScopeLevel && first.type === `pseudo_class` && first.value === `global`; |
There was a problem hiding this comment.
the change is here - the addition of rootScopeLevel && to limit the behavior of not prepending the parent scope for root mixins
barak007
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fix the code that combines 2 selectors into a single selector in order to fix 2 bugs:
@st-scope, the parent selector is ignored:global()is missing the mixed into selector