-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: move to file-services/resolve as default resolver #2907
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks promising, but I've noticed a few issues that I've commented on. Additionally, there's one more thing that I think should be tested:
The Webpack-Plugin
currently conducts tests solely with its own resolver. Could you please include a test to ensure that the new default resolver can be integrated and functions correctly? I believe it's essential to guide users in this direction, especially if they have a setup involving multiple integrations and need the resolver to operate consistently across all of them.
Let's review it one more time to ensure that we haven't overlooked anything.
refactor!: reduce minimalFS api
This PR replaces
enhanced-resolve
default resolver with@file-services/resolve
which is much faster and easier to use.Notes:
createDefaultResolver
is now available from the@stylable/webpack-plugin
package and also used by default in italias
.resolveOptions