Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix large title styles #6489

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Fix large title styles #6489

merged 1 commit into from
Aug 20, 2020

Conversation

yogevbd
Copy link
Collaborator

@yogevbd yogevbd commented Aug 20, 2020

On iOS 13, title attributes should be applied on scrollEdgeAppearance as it applied on standardAppearance.
@guyca We need to think about adding more options to control those two states.

Closes #6337

@guyca guyca merged commit e845afe into master Aug 20, 2020
@guyca guyca deleted the fixLargeTitleAttributes branch August 20, 2020 11:54
@chrise86
Copy link

chrise86 commented Sep 14, 2020

Sorry @guyca but this still seems to be broken in RNN 6.12.2. Setting the following either directly on a screen's options or in the default options does not work:

largeTitle: {
  color: 'red', // or whatever colour
}

EDIT: it seems this was merged and released in to 7.0.0, all good on there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] LargeTitle is broken
3 participants