Road to implicitAny part 4 #4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guyca Thx for merging my last PR so quickly! Here is next follow up :D |
guyca
requested changes
Dec 25, 2018
| @@ -7,22 +7,24 @@ import { | |||
| SearchBarUpdatedEvent, | |||
| SearchBarCancelPressedEvent, | |||
| PreviewCompletedEvent, | |||
| ModalDismissedEvent | |||
| ModalDismissedEvent, | |||
There was a problem hiding this comment.
Can we avoid adding comma character where it's avoidable?
| @@ -31,39 +33,57 @@ export class NativeEventsReceiver { | |||
| return this.emitter.addListener('RNN.AppLaunched', callback); | |||
| } | |||
|
|
|||
| public registerComponentDidAppearListener(callback: (event: ComponentDidAppearEvent) => void): EventSubscription { | |||
| public registerComponentDidAppearListener( | |||
There was a problem hiding this comment.
Lets return these method declarations to single line - I think it's readable enough in a single line.
|
I have now done the changes you requested :) |
guyca
approved these changes
Dec 25, 2018
vshkl
pushed a commit
to vshkl/react-native-navigation
that referenced
this pull request
Feb 5, 2020
What is this? This PR continues the work on making this project type safe with TypeScript. Goal is that the flag noImplicitAny will be set to true What this PR does? * all files inside adapter folder is valid for noImplicitAny! * resolveAssetSource is now imported from the current place where it should. Previously it was imported from legacy location. More info here: https://facebook.github.io/react-native/docs/image#resolveassetsource * formatted many files * add missing interfaces * fix onPressIn prop on TouchablePreview What's next? Next I am planning to make same treatment for commands folder and many it valid for noImplicitAny 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This PR continues the work on making this project type safe with TypeScript. Goal is that the flag
noImplicitAnywill be set totrueWhat this PR does?
adapterfolder is valid fornoImplicitAny!resolveAssetSourceis now imported from the current place where it should. Previously it was imported from legacy location. More info here: https://facebook.github.io/react-native/docs/image#resolveassetsourceonPressInprop onTouchablePreviewWhat's next?
Next I am planning to make same treatment for
commandsfolder and many it valid fornoImplicitAny🎉