Fix closing SideMenu when pushing a screen #4491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pushing a screen into a stack in the centre controller with `sideMenu.left/right.visible: false` - side menu was not closed as expected. This happened because when either side menus is open, it’s considered the current child and when options are resolved. the centre controller’s options were ignored. This commit fixes this issue on Android. When resolving options, the centre controllers options are resolved as well. Related to #4267
vshkl
pushed a commit
to vshkl/react-native-navigation
that referenced
this pull request
Feb 5, 2020
When pushing a screen into a stack in the centre controller with `sideMenu.left/right.visible: false` - side menu was not closed as expected. This happened because when either side menus is open, it’s considered the current child and when options are resolved. the centre controller’s options were ignored. This commit fixes this issue on Android. When resolving options, the centre controllers options are resolved as well. Related to wix#4267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pushing a screen into a stack in the centre controller with
sideMenu.left/right.visible: false- side menu was not closed as expected.This happened because when either side menus is open, it’s considered the current child and when options are resolved. the centre controller’s options were ignored.
This commit fixes this issue on Android. When resolving options, the centre controllers options are resolved as well.
Related to #4267