Skip to content

Commit

Permalink
Remove broken bootstrap method (#6528)
Browse files Browse the repository at this point in the history
Without a delegate there is no support for source url and extra modules which are both needed since v7.

@guyca Maybe I missed something in your v7 commit, but it currently doesn't work without a delegate as the `RCTBridgeDelegate` wrapper in `RNNBridgeManager` was removed. So there is no fallback anymore if user doesn't provide a delegate.

Co-authored-by: Yogev Ben David <yogev132@gmail.com>
  • Loading branch information
danilobuerger and yogevbd authored Sep 6, 2020
1 parent e02ec61 commit 5c5ec9e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
2 changes: 0 additions & 2 deletions lib/ios/ReactNativeNavigation.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ typedef UIViewController * (^RNNExternalViewCreator)(NSDictionary* props, RCTBri

@interface ReactNativeNavigation : NSObject

+ (void)bootstrapWithlaunchOptions:(NSDictionary *)launchOptions;

+ (void)bootstrapWithDelegate:(id<RCTBridgeDelegate>)bridgeDelegate launchOptions:(NSDictionary *)launchOptions;

+ (NSArray<id<RCTBridgeModule>> *)extraModulesForBridge:(RCTBridge *)bridge;
Expand Down
4 changes: 0 additions & 4 deletions lib/ios/ReactNativeNavigation.m
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ @implementation ReactNativeNavigation

# pragma mark - public API

+ (void)bootstrapWithlaunchOptions:(NSDictionary *)launchOptions {
[[ReactNativeNavigation sharedInstance] bootstrapWithDelegate:nil launchOptions:launchOptions];
}

+ (void)bootstrapWithDelegate:(id<RCTBridgeDelegate>)bridgeDelegate launchOptions:(NSDictionary *)launchOptions {
[[ReactNativeNavigation sharedInstance] bootstrapWithDelegate:bridgeDelegate launchOptions:launchOptions];
}
Expand Down

0 comments on commit 5c5ec9e

Please sign in to comment.