-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add -R, --retries <count> option #2269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noomorph
commented
Aug 12, 2020
d4vidi
reviewed
Aug 12, 2020
rotemmiz
reviewed
Aug 12, 2020
f21be35
to
58c8250
Compare
This was referenced Aug 19, 2020
58c8250
to
bcc0985
Compare
bcc0985
to
800d34f
Compare
9ed0bc2
to
98ae0fe
Compare
98ae0fe
to
840e511
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2073 for users who temporarily cannot rewrite their test suites to make them adhere to
jest.retryTimes(n)
guidelines. The idea is to keep re-running failed test suites (or files, to be more precise) before either we run out of attempt or succeed with those flaky tests.This is not a recommended method since it assumes, for example, that if in a 100-tests suite even 1 test fails, we will be re-running the entire test file with those 100 tests again.
To-dos
decide what do we do if users write into the sameNow, we support this case: you'll just see (1) (2) (3) prefixes.artifacts-location
since it is apt to generate suppressed I/O errors in the logs (that is the case when there is no autogeneratedios.sim.release.2020-08-12 13-02-42Z
suffix, onlyartifacts/
folder directly).preceed this PR with the one that fixesenv.PATH
resolution indetox-cli
npm package (notlocal-cli
one).remove remnants of env.PATH PR from this PRcheckpackage.json
dependencies (maybe some of them should be optional or peer dependencies)check if we can add Mocha support with 5-15 lines(we cannot because Mocha does not support multiple reporters yet) disable the feature for Mocha-R
test case forlocal-cli/test.test.js
splitArgv.js
file with tests--debug-synchronization e2e/01.sanity.test.js
issue (incorrect boolean handling)