Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troubleshoot legacy witnessing elegibility on the testnet #2527

Closed
aesedepece opened this issue Nov 18, 2024 · 1 comment · Fixed by #2532
Closed

Troubleshoot legacy witnessing elegibility on the testnet #2527

aesedepece opened this issue Nov 18, 2024 · 1 comment · Fixed by #2532
Assignees
Labels
2.0 bug 🐜 Something isn't working security 🛡️ Changes that affect software security for the good or the bad
Milestone

Comments

@aesedepece
Copy link
Member

Apparently, witnessing eligibility using the legacy implementation while in protocol version 1.7 / 1.8 is broken.

Namely, the eligibility proofs being produced in 1.7 / 1.8 fail to pass the verification checks that those very same protocol versions enforce.

Eligibility is covered by tests, so I'm assuming that the issue lies in actor business logic. E.g. we may have a bad comparison in one of the protocol version checks, or a wrongly versioned hash is being passed to the verification functions, etc.

@aesedepece aesedepece added bug 🐜 Something isn't working 2.0 security 🛡️ Changes that affect software security for the good or the bad labels Nov 18, 2024
@aesedepece aesedepece added this to the 2.0.0-rc.3 milestone Nov 18, 2024
@aesedepece aesedepece self-assigned this Nov 18, 2024
@aesedepece
Copy link
Member Author

[2024-11-18T12:01:30Z WARN  isahc::handler] request completed with error: failed to resolve host name
[2024-11-18T12:01:30Z DEBUG witnet_rad] Successful result for source https://www.bitstamp.net/api/ticker/: Float(RadonFloat { value: 90390.0 })
[2024-11-18T12:01:30Z DEBUG witnet_rad] Successful result for source https://api.coindesk.com/v1/bpi/currentprice.json: Float(RadonFloat { value: 90431.2659 })
[2024-11-18T12:01:30Z WARN  witnet_rad::types] `RadError` cannot be converted to `RadonError` but it should, because it is needed for the tally result. Message: None. Inner: `Some(HttpOther { message: "HTTP request error. Underlying error: failed to resolve host name" })`
[2024-11-18T12:01:30Z WARN  witnet_node::actors::chain_manager] Error when validating transaction d5581b5326bad94802acb66299d026b44320033f080b4de24c06b62aa6b55c85: Commit transaction has a invalid Proof of Eligibility
[2024-11-18T12:01:30Z WARN  witnet_node::actors::chain_manager::handlers] Failed to add commit transaction: Commit transaction has a invalid Proof of Eligibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 bug 🐜 Something isn't working security 🛡️ Changes that affect software security for the good or the bad
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant