-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add local file storage for dev environments #2928
Add local file storage for dev environments #2928
Conversation
This is awesome! One request: could we add documentation around this to the setup guide? Might even call for a new subsection "Working with image uploads locally" or something Will test this locally after that! |
@brianlovin I think its good to go. Flow errors have been fixed, and I've added some notes to the README under starting the API. |
Sorry, now that I'm actually using this - what would you think of just setting that |
Sorted. I was worried that it would affect the dev experience for people already working on Spectrum, but upload returns URLs, so images that have already been uploaded to S3 should still show up fine. |
This looks great to me and works locally - would love a look from @mxstbr but otherwise this is good to go :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thank you so much!
Status
Deploy after merge (delete what needn't be deployed)
Release notes for users (delete if codebase-only change)
FILE_STORAGE
env variable, it'll default to original S3 logic.public/uploads
dir, which will be created if it doesn't existpublic/uploads
has been added to .gitignoreThis PR will allow contributors to work with image uploads without requiring AWS keys/secrets. It should also be easier to add new implementations in the future.
If this is something that y'all would like to have, it would be good to test with and without AWS keys.