This repository has been archived by the owner on Oct 11, 2022. It is now read-only.
Fixing tests #2881
Merged
Fixing tests #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianlovin
reviewed
Apr 16, 2018
| @@ -72,7 +72,7 @@ class ChannelList extends React.Component<Props> { | |||
| }) | |||
| ) | |||
| } | |||
| dataCy="create-channel-button" | |||
| data-cy="create-channel-button" | |||
There was a problem hiding this comment.
I think Buttons are passing through the props here, and we use dataCy to indicate that the prop is being passed to another element further down the tree. Does this change fix the text?
There was a problem hiding this comment.
You are right dataCy is passed down, I will revert that with the next test fix commit.
mxstbr
approved these changes
Apr 17, 2018
There was a problem hiding this comment.
Already much better so I'll ship this, thanks so much for investigating! Seems like the rest is up to @brianlovin?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Initial approach to make the test on CI passing more consistently.