Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version 1.7.1 #45

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Add version 1.7.1 #45

merged 2 commits into from
Dec 8, 2023

Conversation

phemmylintry
Copy link
Contributor

No description provided.

@phemmylintry phemmylintry requested a review from a team December 1, 2023 13:05
@phemmylintry phemmylintry linked an issue Dec 1, 2023 that may be closed by this pull request
Add version 1.7.1 #43
Closed
parisk
parisk requested changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment •
edited by phemmylintry
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phemmylintry let's rebase and run this against #44, as a chained PR. We should:

@parisk
Copy link
Contributor

parisk commented Dec 4, 2023

@phemmylintry also please fix ARG syntax, which was broken #44 and slipped the review, but fixed in #46.

@phemmylintry phemmylintry requested a review from parisk December 4, 2023 13:10
gmargaritis
gmargaritis requested changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@gmargaritis gmargaritis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phemmylintry 52e4299 appears to be stale, since in c4f6862 we replaced buster with bookworm. We'll need to merge the latest main once more.

gmargaritis
gmargaritis previously approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@gmargaritis gmargaritis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍰

parisk
parisk requested changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's squash commits and we should be good to go.

@phemmylintry
Add version 1.7.1
4018e38 
add version 1.7.1

Fix: Replace `buster` with `bookworm`

update
@phemmylintry phemmylintry requested a review from parisk December 8, 2023 11:36
@phemmylintry phemmylintry dismissed gmargaritis’s stale review December 8, 2023 11:37

The merge-base changed after approval.

parisk
parisk approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦌

@phemmylintry phemmylintry merged commit cb289dd into main Dec 8, 2023
@phemmylintry phemmylintry deleted the bump/poetry-1.7.1 branch December 8, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

@gmargaritis gmargaritis gmargaritis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add version 1.7.1
3 participants
@phemmylintry @parisk @gmargaritis