Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese language support & translate some docs into Japanese #97

Merged
merged 4 commits into from
May 29, 2023

Conversation

morinokami
Copy link
Contributor

@morinokami morinokami commented May 29, 2023

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content
  • Changes to Starlight code

Description

  • Add Japanese language support.
  • Translate some pages of the docs into Japanese.

@changeset-bot
Copy link

changeset-bot bot commented May 29, 2023

🦋 Changeset detected

Latest commit: 9a1cdfd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented May 29, 2023

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 9a1cdfd
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/64750d78b204f100080f8f70
😎 Deploy Preview https://deploy-preview-97--astro-starlight.netlify.app/ja
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@morinokami
Copy link
Contributor Author

morinokami commented May 29, 2023

Hi, @delucis. While this PR includes changes to the Starlight code, the majority of the changes are translations. Should I add a changeset in this case?

@delucis
Copy link
Member

delucis commented May 29, 2023

Thanks for this @morinokami!

Yes, we should add a patch changeset so that the next release notes say that Japanese support was added 🥳

You can add one by running pnpm changeset add in the repo or clicking the “add a changeset” link in the bot message above. Let me know if you have any questions.

We should also update this line in the i18n docs to mention Japanese support:

We aim to ship these labels in as many languages as possible but currently only have support for English, German, and Spanish.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @morinokami. I made those changes so I can release this tonight — will also make one more tweak.

docs/src/content/docs/ja/index.mdx Outdated Show resolved Hide resolved
@delucis delucis changed the title Add Japanese language support and translate some docs into Japanese Add Japanese language support & translate some docs into Japanese May 29, 2023
@delucis delucis merged commit 2d51762 into withastro:main May 29, 2023
@astrobot-houston astrobot-houston mentioned this pull request May 29, 2023
@morinokami
Copy link
Contributor Author

@delucis Ah, it was the middle of the night in Japan, so I had to stop working on it😅 Thank you for taking over and completing the rest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants