-
-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Japanese language support & translate some docs into Japanese #97
Conversation
🦋 Changeset detectedLatest commit: 9a1cdfd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi, @delucis. While this PR includes changes to the Starlight code, the majority of the changes are translations. Should I add a changeset in this case? |
Thanks for this @morinokami! Yes, we should add a patch changeset so that the next release notes say that Japanese support was added 🥳 You can add one by running We should also update this line in the i18n docs to mention Japanese support:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @morinokami. I made those changes so I can release this tonight — will also make one more tweak.
@delucis Ah, it was the middle of the night in Japan, so I had to stop working on it😅 Thank you for taking over and completing the rest! |
What kind of changes does this PR include?
Description