Fix language switcher trailingSlash edge case
#2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e8b0e2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
HiDeoo
approved these changes
Nov 19, 2024
Merged
HiDeoo
added a commit
to HiDeoo/starlight
that referenced
this pull request
Nov 22, 2024
* main: Add issue and discussion templates for documentation improvements (withastro#2619) [ci] release (withastro#2618) Fix language switcher `trailingSlash` edge case (withastro#2616)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
trailingSlashis not respected for the multilingual sites selector #2609<head>metadata) even when Astro’strailingSlash: 'never'was set.Astro.urlwhich is already in the correct format.URLobject can never have apathnameof"". Settingpathname = ""still results in apathnameof"/". This means that when prefixing a root locale homepage, we can’t rely only onpathnameto know if a trailing slash should be present or not.trailingSlashoption.trailingSlashconfig a parameter to ourlocalizedUrl()utility as this makes testing simpler, rather than importing the user config into the utility directly which would mean having to set up two separate test environments. But open to feedback if people think it would be better to avoid the extra parameter.