-
-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(de): update translation reference/configuration #2459
Conversation
|
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Link fixed in #2458 |
Link fixed in #2464 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update 🙌
As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist. Left a few comments regarding some missing changes but otherwise, this looks good to me.
@@ -131,7 +153,7 @@ Autogenerierte Untergruppen respektieren standardmäßig die Eigenschaft `collap | |||
sidebar: [ | |||
// Eine zusammengefasste Gruppe von Links | |||
{ | |||
label: 'Collapsed Links', | |||
label: 'Zusammengeklappte Links', | |||
collapsed: true, | |||
items: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example seems to be missing the changes from https://github.com/withastro/starlight/pull/1874/files#diff-889e6ae5a36c15d03a30012e2936df94a63753b335bd5a8c56fac9a42e5c1dff and also proper highlights.
@@ -398,7 +527,7 @@ Eine Seite kann diese Einstellung oder den Linktext und/oder die URL mit Hilfe d | |||
### `favicon` | |||
|
|||
**Typ:** `string` | |||
**Standard:** `'/favicon.svg'` | |||
**Voreinstellung:** `'/favicon.svg'` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot suggest a change for it as it's outside of the review range but the second example in this section is missing the change from https://github.com/withastro/starlight/pull/1627/files#diff-889e6ae5a36c15d03a30012e2936df94a63753b335bd5a8c56fac9a42e5c1dff
Thanks for the review! I think it should be good to go... I'm working from a smartphone, so I would really appreciate it if you check especially the highlighting of the code block mentioned and general if all missing changes are now translated! Thanks in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the PR, everything looks good now 🚀 I'll temporarily merge with broken links so they can be fixed in the next PRs.
* main: (240 commits) i18n(de): update some files for consistency in German language (withastro#2502) i18n(zh-cn): Update `plugins.mdx` (withastro#2501) i18n(de): translate guides/pages (withastro#2469) i18n(de): translate components/code (withastro#2457) i18n(de): translate components/using-components (withastro#2455) [ci] format i18n(de): translate guides/site-search (withastro#2481) i18n(de): update translation guides/customization (withastro#2475) i18n(de): update translation manual-setup (withastro#2479) i18n(de): update translation reference/overrides (withastro#2480) i18n(de): translate reference/plugins (withastro#2464) i18n(de): update translation guides/authoring-content (withastro#2458) [ci] format i18n(de): update translation reference/configuration (withastro#2459) i18n(de): update translation reference/frontmatter (withastro#2470) [ci] format i18n(de): update translation guides/i18n (withastro#2476) i18n(de): update `resources/plugins.mdx` (withastro#2498) i18n(ko-KR): update `plugins.mdx` (withastro#2500) i18n(fr): Update `resources/plugins` from withastro#2493 (withastro#2496) ...
Description
Translation of
reference/configuration.mdx
into German language.