Add new social icon for Zulip #1978
Conversation
🦋 Changeset detectedLatest commit: 57b760c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hello! Thank you for opening your first PR to Starlight! ✨ Here’s what will happen next:
|
There was a problem hiding this comment.
Thanks for adding this @kylewlacy! Noticed on small opportunity for improvement, but otherwise this PR looks perfect 🙌
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Description
Closes #1952. This PR adds a new social icon for the chat platform Zulip. Here's how the new logo would look on the Starlight docs site (to the right of the Discord and GitHub logos):
I based the logo on the file
zulip-icon-circle.svgfrom the Zulip repo. The repo is Apache 2.0-licensed, but based on zulip/zulip#13906, my impression was that the Zulip team didn't have a specific license for their logo but were open to usage when used for linking to Zulip itself (I will post in that issue to see if they would have any concerns about this PR as well, for good measure).The original SVG itself featured the background circle and the inner "Z" as separate elements, so I basically just grabbed the "Z", scaled/positioned it, and saved it as its own SVG. I also tried having a negative "Z" within a circle, but felt that didn't read as well at a smaller scale.