Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(ko-KR): update sidebar.mdx #1760

Merged
merged 9 commits into from
Apr 16, 2024
Merged

i18n(ko-KR): update sidebar.mdx #1760

merged 9 commits into from
Apr 16, 2024

Conversation

jsparkdev
Copy link
Contributor

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d1bcdc0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Apr 16, 2024 0:42am

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Apr 15, 2024
HiDeoo
HiDeoo reviewed Apr 15, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, this is looking really great.

Small question: I noticed you did not translate the new examples (they can safely be translated). Is this intentional? Do you think it would be better to leave them in English? Is this a domain-specific where English is more common? For example, if I am not wrong, Andromeda is 안드로메다자리 and we have more generic terms like "stars", "constellations", "moons", etc. that I guess could be translated?

Just a question of course, you definitely know better than me what is best in this case so feel free to tell me if I am wrong and things are better this way.

@jsparkdev
Copy link
Contributor Author

Thank you!

I translated the content that I thought was natural to translate.

I left badges containing "New", "Outdated", and "Stub" as is because I thought it would be better not to translate them.

HiDeoo
HiDeoo requested changes Apr 16, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking the time to update the translation, this looks amazing and what you did not change makes total sense to me.

I left a few suggestions for the case of no config or folders in autogenerated groups where the folder names are used (as we have no API at the moment to properly translate them) but once fixed, this is ready to go 🚀

docs/src/content/docs/ko/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/ko/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/ko/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/ko/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/ko/guides/sidebar.mdx Outdated Show resolved Hide resolved
jsparkdev and others added 5 commits April 16, 2024 20:31
@jsparkdev @HiDeoo
Update docs/src/content/docs/ko/guides/sidebar.mdx
7cbe6ff 
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
@jsparkdev @HiDeoo
Update docs/src/content/docs/ko/guides/sidebar.mdx
e5c5cf4 
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
@jsparkdev @HiDeoo
Update docs/src/content/docs/ko/guides/sidebar.mdx
e69b999 
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
@jsparkdev @HiDeoo
Update docs/src/content/docs/ko/guides/sidebar.mdx
7ff0432 
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
@jsparkdev @HiDeoo
Update docs/src/content/docs/ko/guides/sidebar.mdx
938206e 
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
@jsparkdev
Copy link
Contributor Author

Thank you. Added suggestions for default sidebar and autogenerated group.

HiDeoo
HiDeoo approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for your patience, this looks great 🌟 (I pushed a tiny commit to add a missing quote introduced by one of my suggestions 🥲)

@HiDeoo HiDeoo merged commit b2c50ea into withastro:main Apr 16, 2024
9 checks passed
@jsparkdev jsparkdev deleted the sidebar branch April 16, 2024 12:44
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Apr 22, 2024
@HiDeoo
Merge branch 'main' into hd-style-details
ade0395 
* main: (32 commits)
  i18n(pt-br): Update `getting-started.mdx` (withastro#1776)
  i18n(es): update `configuration` (withastro#1766)
  [ci] format
  Add TrueCharts to showcases (withastro#1773)
  i18n(zh-cn): Update `sidebar.mdx` (withastro#1761)
  i18n(ko-KR): update `sidebar.mdx` (withastro#1760)
  i18n(fr): update `guides/sidebar` (withastro#1758)
  test: fix Windows path separator test issues (withastro#1759)
  i18n(fr): Update `reference/configuration.mdx` from withastro#1729 (withastro#1757)
  docs: rewrite `guides/sidebar` examples to be more generic (withastro#1751)
  i18n(ja): Update community-content.mdx (withastro#1756)
  i18n(ja): Update configuration.mdx (withastro#1755)
  i18n(zh-cn): Update `configuration.mdx` (withastro#1753)
  i18n(ko-KR): update `configuration.mdx` (withastro#1752)
  docs: add caution about scripts processing when using head config (withastro#1729)
  i18n(es): update `community-content` (withastro#1740)
  i18n(pt-br): Update `resources/community-content.mdx` (withastro#1747)
  format: quick fix
  [ci] format
  [ci] format
  ...
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Apr 30, 2024
@HiDeoo
Merge branch 'main' into hd-feat-tabs-sync
f682d22 
* main: (21 commits)
  Update fa.json (withastro#1793)
  i18n(fr): update `resources/community-content.mdx` (withastro#1795)
  [ci] format
  i18n(ko-KR): update `community-content.mdx` (withastro#1794)
  [ci] format
  Adds Starlight in Next.js project video (withastro#1789)
  [ci] format
  i18n(ru): update translations (withastro#1783)
  i18n(id): Update getting-started.mdx (withastro#1778)
  Upgrade Lunaria and add Action (withastro#1768)
  [ci] format
  i18n(es): update `sidebar` (withastro#1767)
  i18n(pt-br): Update `getting-started.mdx` (withastro#1776)
  i18n(es): update `configuration` (withastro#1766)
  [ci] format
  Add TrueCharts to showcases (withastro#1773)
  i18n(zh-cn): Update `sidebar.mdx` (withastro#1761)
  i18n(ko-KR): update `sidebar.mdx` (withastro#1760)
  i18n(fr): update `guides/sidebar` (withastro#1758)
  test: fix Windows path separator test issues (withastro#1759)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsparkdev @HiDeoo