Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(fr): Update guides/customization.mdx with <Steps> #1650

Merged
merged 3 commits into from
Mar 21, 2024
Merged

i18n(fr): Update guides/customization.mdx with <Steps> #1650

merged 3 commits into from
Mar 21, 2024

Conversation

thomasbnt
Copy link
Member

Description

i18n(fr): Update guides/customization.mdx with from 554c670

@thomasbnt
i18n(fr): Update guides/customization.mdx with <Steps> from 554c670
d32402b 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8640a22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Mar 21, 2024 10:20am

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Mar 20, 2024
dreyfus92
dreyfus92 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci @thomasbnt, LGTM ✅

HiDeoo
HiDeoo approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, I'm reverting a translation from French to English for mon-logo.svg as it's fine in French and the mon-logo.svg is used in later example so we cannot revert it only in 1 place.

docs/src/content/docs/fr/guides/customization.mdx Outdated Show resolved Hide resolved
@HiDeoo HiDeoo merged commit 20e69b8 into withastro:main Mar 21, 2024
9 checks passed
@thomasbnt
Copy link
Member Author

Thanks @HiDeoo and @dreyfus92 💜🙌

HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Mar 26, 2024
@HiDeoo
Merge branch 'main' into hd-feat-tabs-sync
e7e9f30 
* main: (419 commits)
  i18n(fr): Update `guides/i18n.mdx` with <Steps> (withastro#1652)
  i18n(es): update `site-search` (withastro#1666)
  i18n(fr): Update `resources/plugins.mdx` with LinkCard Zoom (withastro#1654)
  i18(zh-cn): Update i18n.mdx (withastro#1672)
  i18(zh-cn): Update customization.mdx (withastro#1671)
  [ci] format
  i18n(it): Update css-and-tailwind.mdx (withastro#1643)
  [ci] format
  i18n(it): Update customization.mdx (withastro#1642)
  [ci] format
  i18n(es): update `overriding-components` (withastro#1670)
  i18n(fr): Update `guides/customization.mdx` with <Steps> (withastro#1650)
  [ci] format
  i18n(es): update `css-and-tailwind` (withastro#1669)
  i18n(es): updates `customization` (withastro#1668)
  i18n(it): Update i18n.mdx (withastro#1645)
  i18n(es): update `i18n` (withastro#1667)
  i18n(it): Update site-search.mdx (withastro#1644)
  [ci] format
  i18n(fr): Update `guides/overriding-components.mdx` in MDX format and with <Steps> (withastro#1655)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreyfus92 dreyfus92 dreyfus92 approved these changes

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasbnt @HiDeoo @dreyfus92