Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(ja): Add pages.mdx #1524

Merged
merged 4 commits into from
Feb 18, 2024
Merged

i18n(ja): Add pages.mdx #1524

merged 4 commits into from
Feb 18, 2024

Conversation

morinokami
Copy link
Contributor

Description

  • Add pages.mdx.

@vercel Vercel
Copy link

vercel bot commented Feb 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Feb 18, 2024 5:21pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4850bd8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Feb 18, 2024
HiDeoo
HiDeoo reviewed Feb 18, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation 🙌

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist. Everything looks good to me and only left 1 small question 👍

docs/src/content/docs/ja/guides/pages.mdx Outdated

```md
---
title: Hello, World!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Hello, World!
title: こんにちは、世界！

I noticed this was originally translated in the getting started guide. Do you think this makes sense or it's better to keep it as-is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!! I think it's better to translate the title.

@morinokami morinokami requested a review from HiDeoo February 18, 2024 14:54
HiDeoo
HiDeoo approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for the follow up and the translation 🙌

@HiDeoo HiDeoo merged commit d51b69d into withastro:main Feb 18, 2024
9 checks passed
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Feb 20, 2024
@HiDeoo
Merge branch 'main' into hd-file-tree
7e91fb8 
* main: (34 commits)
  i18n(ja): Update customization.mdx (withastro#1526)
  [ci] format
  i18n(zh-cn): Update manual-setup.mdx (withastro#1522)
  i18n(zh-cn): Update community-content.mdx (withastro#1520)
  Add Astro-GhostCMS to showcase (withastro#1529)
  [ci] format
  i18n(zh-cn): Update components.mdx (withastro#1513)
  i18n(zh-cn): Update getting-started.mdx (withastro#1510)
  [ci] format
  i18n(zh-cn): Translate pages.mdx (withastro#1523)
  i18n(ja): Add pages.mdx (withastro#1524)
  [ci] format
  i18n(fr): Update `guides/components` and `getting-started` (withastro#1506)
  i18n(ja): Update components.mdx (withastro#1514)
  i18n(ja): Update sidebar.mdx (withastro#1511)
  i18n(ja): Update configuration.mdx (withastro#1515)
  i18n(ja): Update getting-started.mdx (withastro#1507)
  i18n(ja): Update site-search.mdx (withastro#1512)
  i18n(ja): Add showcase.mdx (withastro#1516)
  i18n(ja): Add plugins.mdx (withastro#1519)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morinokami @HiDeoo