Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(es): Update customization.mdx & configuration.mdx #1425

Merged
merged 4 commits into from
Jan 29, 2024
Merged

i18n(es): Update customization.mdx & configuration.mdx #1425

merged 4 commits into from
Jan 29, 2024

Conversation

dreyfus92
Copy link
Member

Description

  • Closes # N/A
  • What does this PR change? Give us a brief description.
    Updates customization.mdx & configuration.mdx based on this commit 21b3620 & cae82bc

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 227cac2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Jan 29, 2024 1:27pm

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Jan 29, 2024
Waxer59
Waxer59 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@Waxer59 Waxer59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

delucis
delucis reviewed Jan 29, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dreyfus92! Just one change after we had to fix something in the English version 🙌

docs/src/content/docs/es/reference/configuration.mdx Outdated Show resolved Hide resolved
@dreyfus92 @delucis
Applied suggestion's from Chris' review.
227cac2 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@dreyfus92
Copy link
Member Author

Thank you both @Waxer59 & @delucis for your reviews 😁

kevinzunigacuellar
kevinzunigacuellar approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@kevinzunigacuellar kevinzunigacuellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 Thanks @Waxer59 and @dreyfus92

delucis
delucis approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go, thanks team!

@delucis delucis merged commit dea532f into withastro:main Jan 29, 2024
9 checks passed
@dreyfus92 dreyfus92 deleted the updates-86 branch April 10, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Waxer59 Waxer59 Waxer59 approved these changes

@kevinzunigacuellar kevinzunigacuellar kevinzunigacuellar approved these changes

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dreyfus92 @delucis @kevinzunigacuellar @Waxer59