Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore original tighter line-height on <LinkCard> titles #1386

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Jan 19, 2024

Description

An example of the change:

Before After
Three link cards with titles that wrap across two lines The same three link cards with titles that now have narrower line height

Docs pages with link cards:

Copy link

changeset-bot bot commented Jan 19, 2024

🦋 Changeset detected

Latest commit: ca40ecd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Jan 19, 2024 1:17pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
starlight-i18n ⬜️ Ignored (Inspect) Jan 19, 2024 1:17pm

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Jan 19, 2024
@astrobot-houston
Copy link
Collaborator

size-limit report 📦

Path Size
/index.html 5.22 KB (+0.06% 🔺)
/_astro/*.js 21.44 KB (0%)
/_astro/*.css 13.13 KB (0%)

@delucis delucis added the 🌟 minor Change that triggers a minor release label Jan 19, 2024
Copy link
Member Author

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheekily interpreting #1357 (comment) as an approval from @HiDeoo to get this merged 😁

@delucis delucis merged commit 0163634 into main Jan 19, 2024
10 checks passed
@delucis delucis deleted the chris/link-card-titles branch January 19, 2024 13:39
@astrobot-houston astrobot-houston mentioned this pull request Jan 19, 2024
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Jan 23, 2024
* main: (23 commits)
  i18n(ko-KR): add`plugins.mdx` (withastro#1401)
  [ci] format
  i18n(ko-KR): add `community-content.mdx` (withastro#1402)
  i18n(ko-KR): update `site-search.mdx` (withastro#1400)
  i18n(ko-KR): add `showcase.mdx` (withastro#1403)
  [docs] new Resources sidebar section and pages (withastro#1357)
  i18n(hi): add `i18n.mdx` (withastro#1388)
  [ci] format
  [ci] release (withastro#1384)
  Restore original tighter line-height on `<LinkCard>` titles (withastro#1386)
  Refactor virtual module system for layout components (withastro#1383)
  Update astro to 4.2.1 (withastro#1385)
  fix: tree generation for autogenerated groups (withastro#1151)
  Tweak vertical spacing in Markdown content styles (withastro#1376)
  Update ToC highlighting styles to prevent UI shifts (withastro#1372)
  i18n(hi): update `index.mdx` (withastro#1380)
  [ci] format
  [ci] release (withastro#1379)
  Update dependencies (withastro#1378)
  [ci] format
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 minor Change that triggers a minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants