fix: minor type issues in starlight (#1706)

Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
withastro · Apr 9, 2024 · f171ac4 · f171ac4
1 parent c5cd181
commit f171ac4
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/shaggy-crabs-press.md b/.changeset/shaggy-crabs-press.md
@@ -0,0 +1,5 @@
+---
+'@astrojs/starlight': patch
+---
+
+Fixes some minor type errors
diff --git a/packages/starlight/integrations/shared/pathToLocale.ts b/packages/starlight/integrations/shared/pathToLocale.ts
@@ -1,3 +1,4 @@
+import type { AstroConfig } from 'astro';
 import type { StarlightConfig } from '../../types';
 
 function slugToLocale(
@@ -17,7 +18,7 @@ export function pathToLocale(
 		astroConfig,
 	}: {
 		starlightConfig: { locales: StarlightConfig['locales'] };
-		astroConfig: { root: URL; srcDir: URL };
+		astroConfig: { root: AstroConfig['root']; srcDir: AstroConfig['srcDir'] };
 	}
 ): string | undefined {
 	const srcDir = new URL(astroConfig.srcDir, astroConfig.root);

diff --git a/packages/starlight/user-components/rehype-file-tree.ts b/packages/starlight/user-components/rehype-file-tree.ts
@@ -168,7 +168,7 @@ function getFileIcon(fileName: string) {
 
 /** Return the icon name for a file based on its file name. */
 function getFileIconName(fileName: string) {
-	let icon = definitions.files[fileName];
+	let icon: string | undefined = definitions.files[fileName];
 	if (icon) return icon;
 	icon = getFileIconTypeFromExtension(fileName);
 	if (icon) return icon;