Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the list of acceptable cookie options for Astro.cookies.delete #7814

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Update the list of acceptable cookie options for Astro.cookies.delete #7814

merged 2 commits into from
Apr 10, 2024

Conversation

fshafiee
Copy link

@fshafiee fshafiee commented Apr 8, 2024

Description (required)

A complimentary PR for withastro/astro#10671

For Astro version: 4.6.0. See astro PR #10671

@vercel Vercel
Copy link

vercel bot commented Apr 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Apr 10, 2024 9:45pm

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@fshafiee fshafiee mentioned this pull request Apr 8, 2024
Merged
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Apr 8, 2024
sarah11918
sarah11918 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @fshafiee! Thank you for contributing the extra docs so that people will have a reference of your wonderful new feature! 🙌

And, welcome to Team Docs! 🥳

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Apr 8, 2024
@sarah11918 sarah11918 added this to the 4.6.0 milestone Apr 8, 2024
@sarah11918 sarah11918 changed the base branch from main to 4.6.0 April 10, 2024 21:36
@sarah11918 sarah11918 merged commit 7828b8f into withastro:4.6.0 Apr 10, 2024
2 of 3 checks passed
@sarah11918 sarah11918 mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@fshafiee @astrobot-houston @sarah11918