-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document new routing priority behavior #6386
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work Fryuni! Thank you for documenting all of these rules!
I have left some typo fixes and suggestions for the routing.mdx
file, but not the reference files because I believe those are auto-generated from the JSDocs.
Hope they help!
I am noting that this feature will be released as an experimental flag for 4.2.0, which means that the ONLY documentation should be in the changeset and This PR should not be merged as there will be no wider docs changes (as there never are for experimental flag features changing behaviour. All documentation is contained to the experimental config section). BUT, we can use this to help craft that! We will use withastro/astro#9644 as a model/reference for how to document for an experimental flag that builds on/changes existing features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not to be merged, used in helping us prepare documentation in withastro/astro#9439 only.
Co-authored-by: voxel!() <voxelmc@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last piece of the puzzle! Approved!
Lovely, thanks for sending the changes @sarah11918. You're the best! |
* Update with PR #6440 * Update with PR #6386 * Up with PR #6532 * Up with PR #6436 * Upd Just for Lunaria with PR #6444 * Up with PR #6402 * Up with PR #6548 * Up with PR #6430 * Up with PR #6469 * Up with PR #6522 * Up with PR #6272 * Update src/content/docs/fr/editor-setup.mdx Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com> * Update src/content/docs/fr/reference/publish-to-npm.mdx Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com> --------- Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com> Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Co-authored-by: voxel!() <voxelmc@hotmail.com> Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
* Update with PR #6440 * Update with PR #6386 * Up with PR #6532 * Up with PR #6436 * Upd Just for Lunaria with PR #6444 * Up with PR #6402 * Up with PR #6548 * Up with PR #6430 * Up with PR #6469 * Up with PR #6522 * Up with PR #6272 * Update src/content/docs/fr/editor-setup.mdx Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com> * Update src/content/docs/fr/reference/publish-to-npm.mdx Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com> --------- Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com> Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Document new routing priority behavior (withastro#6386)
* Update routing.mdx in ja Modified to be similar to the English sample code in "Nested Pagination" section * update routing.mdx in ja [code-example-syntax] hippo-proof code examples (#5364) * update routing.mdx in ja fix: add spacing to 'added in' texts (#5765) * update routing.mdx in ja Add <ReadMore> component (#6267) * Update routing.mdx in ja Document new routing priority behavior (#6386) * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> * Update src/content/docs/ja/guides/routing.mdx Co-authored-by: Shinya Fujino <shf0811@gmail.com> --------- Co-authored-by: Shinya Fujino <shf0811@gmail.com> Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Description