-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document inline stylesheets #3355
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I like this section, and I like it where it's located! One quick thing that comes to mind is whether there are any Tailwind implications with this, since so many people will be using Tailwind. Is there something relevant or useful to say about whether or how this does/doesn't include/affect your Tailwind styles? |
Stylesheets created by tailwind would be treated the same as those created by any other source. |
Thanks @lilnasy - do you think some people might need to explicitly hear that? Is this something a Tailwind user might be wondering? Or is it obvious enough. I'm trying to think of what might be going through someone's mind. 😄 |
I haven't used tailwind, so I can't get in the mindset of a user. Whether a reassurance is necessary depends on whether astro+tailwind users are used to things not working without fiddling. |
Although even if that's not the case, two lines couldn't hurt.
|
@sarah11918 Tailwind is a large stylesheet most of the time, so most likely it will be bundled in a chunk that is not inlined. Unless you are only using a small amount of Tailwind styles. So it would be retrieved externally and cached between pages, which is what you want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, @matthewp! I tried some minor text changes but of course as always, may have lost some nuance in the process. See what you think, and take what you like!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh waw! I love this!! 🚀
What kind of changes does this PR include?
Description