Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Content Collections] update to new slug changes #2435

Merged
merged 2 commits into from
Jan 23, 2023
Merged

[Content Collections] update to new slug changes #2435

merged 2 commits into from
Jan 23, 2023

Conversation

FredKSchott
Copy link
Member

What kind of changes does this PR include?

  • New or updated content

Description

@netlify
Copy link

netlify bot commented Jan 23, 2023 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 257d444
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/63ceff5fdf711a0008557696
😎 Deploy Preview https://deploy-preview-2435--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@FredKSchott FredKSchott changed the title update to new slug changes [Content Collections] update to new slug changes Jan 23, 2023
sarah11918
sarah11918 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this change! One line that doesn't read as well as it probably could with more work, but non-blocking!

src/pages/en/guides/content-collections.mdx Outdated Show resolved Hide resolved
bholmesdev
bholmesdev approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on Sarah's commit. But glad we could look at this API slugain!

@FredKSchott @sarah11918
Update src/pages/en/guides/content-collections.mdx
257d444 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@FredKSchott FredKSchott merged commit f796771 into main Jan 23, 2023
@FredKSchott FredKSchott deleted the content-collections-docs-2 branch January 23, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bholmesdev bholmesdev bholmesdev approved these changes

@sarah11918 sarah11918 sarah11918 approved these changes

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FredKSchott @matthewp @sarah11918 @bholmesdev