Adding docs for the new astro:build:generated hook #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This was referenced Sep 15, 2022
|
LGTM! |
sarah11918
reviewed
Sep 21, 2022
delucis
reviewed
Sep 21, 2022
There was a problem hiding this comment.
Seems solid @tony-sull!
A suggestion and a query for you nonetheless 🙌
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
|
Note to all of us that astro PR #4775 has been "approved" but not merged. This shouldn't merge before the hook is active, but also, SHOULD merge WHEN the hook is active. Everyone keep their eyes open! 😄 |
|
Updated note: PR #4775 was just merged in and will go out in tomorrow's |
nokazn
pushed a commit
to nokazn/docs.astro.build
that referenced
this pull request
Oct 2, 2022
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
astro:build:ssrhook docs, it is never fired for SSG builds