Support new script/style behavior #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d0b7945 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
natemoo-re
commented
Apr 2, 2022
| @@ -401,7 +401,7 @@ func render1(p *printer, n *Node, opts RenderOptions) { | |||
| p.print(`]`) | |||
| } else { | |||
| for _, a := range n.Attr { | |||
| if transform.IsImplictNodeMarker(a) { | |||
| if transform.IsImplictNodeMarker(a) || a.Key == "is:inline" { | |||
There was a problem hiding this comment.
This strips is:inline directives from the output
internal/transform/scope-css.go
Outdated
| if hasTruthyAttr(n, "global") { | ||
| if hasTruthyAttr(n, "is:global") { |
There was a problem hiding this comment.
Removed support for global, just supporting is:global. Is that what we want? It's minimal to support both.
There was a problem hiding this comment.
Added a migration warning for global, but still supporting both.
added 2 commits
April 2, 2022 10:41
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
is:inlineandis:globalscriptbehavior,style is:globalastro#2961Testing
Tests updated
Docs
Covered by core PR