Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: route matching for encoded pathnames #9934

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

ktym4a
Copy link
Contributor

@ktym4a ktym4a commented Feb 1, 2024

fix: #9933

Changes

Decode pathnames to check.

Testing

I don't know where to add testcases.
Should I add in dev-routing.test.js? and also add in preview-routing.test.js?

Docs

I don't think to update.

Copy link

changeset-bot bot commented Feb 1, 2024

⚠️ No Changeset found

Latest commit: 9a28bb6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 1, 2024
@matthewp
Copy link
Contributor

matthewp commented Feb 1, 2024

dev-routing.test.js would be great.

The CI failing is unrelated to your change. Sorry about that, we're working on it.

@matthewp matthewp merged commit b176825 into withastro:main Feb 1, 2024
13 checks passed
@ktym4a ktym4a deleted the fix/non-UTF-8file-with-dev-server branch February 16, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev server can't handle non-UTF-8 file name
2 participants