Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silently ignore adapters that don't export start() #9911

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

natemoo-re
Copy link
Member

Changes

Testing

We unfortunately don't have automated adapter tests

Docs

N/A, bug fix only

Copy link

changeset-bot bot commented Jan 31, 2024

🦋 Changeset detected

Latest commit: 80e742e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 31, 2024
Copy link
Contributor

@lilnasy lilnasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reverting this!

Copy link
Member

@alexanderniebuhr alexanderniebuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@natemoo-re natemoo-re merged commit aaedb84 into main Jan 31, 2024
13 checks passed
@natemoo-re natemoo-re deleted the fix/adapter-regression branch January 31, 2024 19:51
@astrobot-houston astrobot-houston mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants