Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view transition's form handling honors default prevention #9486

Merged
merged 4 commits into from
Dec 20, 2023
Merged

view transition's form handling honors default prevention #9486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3d1258
add missing check to honor prevented default
martrapp Dec 20, 2023
204de23
added changeset
martrapp Dec 20, 2023
453b9f9
Update .changeset/fresh-games-confess.md
martrapp Dec 20, 2023
3c5edd6
Merge branch 'main' into mt/preventDefault
martrapp Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fresh-games-confess.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Fixes View Transition's form submission prevention, allowing `preventDefault` to be used.
2 changes: 1 addition & 1 deletion packages/astro/components/ViewTransitions.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ const { fallback = 'animate' } = Astro.props;

document.addEventListener('submit', (ev) => {
let el = ev.target as HTMLElement;
if (el.tagName !== 'FORM' || isReloadEl(el)) {
if (el.tagName !== 'FORM' || ev.defaultPrevented || isReloadEl(el)) {
return;
}
const form = el as HTMLFormElement;
Expand Down
Loading