Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle middleware loading error #9458

Merged
merged 4 commits into from
Dec 19, 2023
Merged

fix: handle middleware loading error #9458

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
360f40e
fix: handle middleware loading error
ematipico Dec 18, 2023
8251d5d
remove the try/catch
ematipico Dec 18, 2023
2cb5d5a
rethrow error
ematipico Dec 18, 2023
47fe703
Update packages/astro/src/core/middleware/loadMiddleware.ts
ematipico Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/selfish-rings-occur.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Correctly handle the error in case the middleware throws a runtime error
7 changes: 1 addition & 6 deletions packages/astro/src/core/middleware/loadMiddleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,5 @@ import { MIDDLEWARE_MODULE_ID } from './vite-plugin.js';
* If not middlewares were not set, the function returns an empty array.
*/
export async function loadMiddleware(moduleLoader: ModuleLoader) {
try {
const module = await moduleLoader.import(MIDDLEWARE_MODULE_ID);
return module;
} catch {
return void 0;
}
return await moduleLoader.import(MIDDLEWARE_MODULE_ID);
}
Loading