Handle unhandledrejections in the dev server #9424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9b9f51b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!preview handle-unhandled |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
ematipico
approved these changes
Dec 13, 2023
Princesseuh
reviewed
Dec 13, 2023
Comment on lines
47
to
53
| function handleUnhandledRejection(rejection: any) { | ||
| const error = new AstroError({ | ||
| ...AstroErrorData.UnhandledRejection, | ||
| message: AstroErrorData.UnhandledRejection.message(rejection?.stack || rejection) | ||
| }) | ||
| logger.error(null, error.message); | ||
| } |
There was a problem hiding this comment.
It's a bit of a edge case, but presumably this should pass through our normal-ish error pipeline so we get a nicely formatted error.
astro/packages/astro/src/core/messages.ts
Line 257 in f8b27b0
How does this look in the browser too?
There was a problem hiding this comment.
It can't pass through the normal error pipeline, it happens outside of the context of a request. You could do: setTimeout(() => Promise.reject('foo'), 5000) and there is no ongoing request, the rejection still happens.
It doesn't currently show up in the browser, do we have a way to send an error from the server to the client outside of a request?
There was a problem hiding this comment.
I would think that from where you are in the code, you'd be able to send to the websocket since you're so close to the server creation, here's how it works in the rendering:
You should just need to send the error payload through the websocket and it should work!»
It can't pass through the normal error pipeline, it happens outside of the context of a request.
If you can't make it go through the entire pipeline, at least formatting the error message would be great:
astro/packages/astro/src/core/messages.ts
Line 257 in f8b27b0
There was a problem hiding this comment.
I'm looking to see if async_hooks can help. https://nodejs.org/api/async_hooks.html
There was a problem hiding this comment.
I think AsyncLocalStorage can maybe allow this, going to give that try.
There was a problem hiding this comment.
And so it begins... I have many ideas for AsyncLocalStorage!
There was a problem hiding this comment.
Updated the PR and it should work now. Updated with a screenshot of what the browser receives. Would appreciate another review @Princesseuh
sarah11918
approved these changes
Dec 13, 2023
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
|
!preview handle-unhandled |
|
Snapshots have been released for the following packages:
Publish LogBuild Log |
matthewp
commented
Dec 13, 2023
| incomingRequest: request, | ||
| incomingResponse: response, | ||
| manifest, | ||
| localStorage.run(request, () => { |
There was a problem hiding this comment.
Passing in the request which acts as the context for the local storage. When an unhandled rejection occurs, we can use this to know which request it was associated with.
There was a problem hiding this comment.
First time I see AsyncLocalStorage in action!
matthewp
commented
Dec 13, 2023
| const store = localStorage.getStore(); | ||
| if(store instanceof IncomingMessage) { | ||
| const request = store; | ||
| setRouteError(controller.state, request.url!, error); |
There was a problem hiding this comment.
This marks the route as being in an error state.
ematipico
approved these changes
Dec 14, 2023
Princesseuh
approved these changes
Dec 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.catch(), will crash the dev server. We can prevent it usingprocess.on('unhandledRejection').Testing
Docs
N/A, bug fix