Error when getImage() is passed an undefined src #9423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6bfe75e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Princesseuh
reviewed
Dec 13, 2023
| if(typeof options.src === 'undefined') { | ||
| throw new AstroError({ | ||
| ...AstroErrorData.ExpectedImage, | ||
| message: AstroErrorData.ExpectedImage.message(options.src, 'undefined', JSON.stringify(options)) |
There was a problem hiding this comment.
This is a bit of a duplicate check from the one in baseService, I do think it's okay though because other services should probably have this check as well.
Princesseuh
approved these changes
Dec 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
getImage({ src: undefined })should throw a good error. Now it does.Testing
Docs
N/A, bug fix