-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Descriptive image error #9352
Descriptive image error #9352
Conversation
🦋 Changeset detectedLatest commit: 8ce1e2a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I believe pnpm link is a thing |
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
@tmcw how did you test your changes? I mean, how did you make sure you could see the new errors? Regardless, here's a suggestion: run Take screenshots to show us the results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tiny adjustments! Great error message!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Changes
Right now, if you have an image in your site that is too big, you get a message saying that an image was too big, but not which one. This PR improves the error so that it tells you which one.
Testing
I really don't know how to test this, tbh - I'd probably use
npm link
but I don't know how that'd work with pnpm.Docs
This doesn't need docs: it's just an improved error.