Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware): instantiate locals if the adapter does not #8800

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Oct 10, 2023

Changes

Testing

Added a case with the node adapter.

Docs

Does not affect usage.

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023

🦋 Changeset detected

Latest commit: 30ce172

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) labels Oct 10, 2023
@lilnasy lilnasy marked this pull request as ready for review October 10, 2023 20:35
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test where we cover the new thrown error?

@natemoo-re natemoo-re merged commit 3917296 into withastro:main Oct 12, 2023
@astrobot-houston astrobot-houston mentioned this pull request Oct 12, 2023
@lilnasy lilnasy deleted the fix/8793 branch October 16, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node adapter: assigning to locals in middleware causes blank 404 page in production build
3 participants