Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure cookies are attached when middleware changes the Response #8612

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Ensure cookies are attached when middleware changes the Response #8612

merged 2 commits into from
Sep 21, 2023

Conversation

matthewp
Copy link
Contributor

Changes

  • When middleware return new Response we need to attach cookies to it.
  • This aligns with how components work as well, if you return a new Response from a page component the cookies that have been set via Astro.cookies.set() go along for the ride.

Testing

New test case added

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 705c9f7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 20, 2023
ematipico
ematipico approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I look at the fix, it seemed so simple 😢

Thank you for looking into it Matthew!

@matthewp matthewp force-pushed the cookies-new-response-middleware branch from f8886bc to 705c9f7 Compare September 21, 2023 12:38
@matthewp matthewp merged commit bcad715 into main Sep 21, 2023
@matthewp matthewp deleted the cookies-new-response-middleware branch September 21, 2023 12:55
@matthewp matthewp mentioned this pull request Sep 21, 2023
Closed
1 task
@astrobot-houston astrobot-houston mentioned this pull request Sep 21, 2023
Merged
@le-u-f
Copy link

le-u-f commented Sep 21, 2023

You rock! Thanks

@i7N3 i7N3 mentioned this pull request Sep 23, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewp @le-u-f @ematipico @bluwy