-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@astro/cloudflare): improve DX for runtime typing #8560
feat(@astro/cloudflare): improve DX for runtime typing #8560
Conversation
🦋 Changeset detectedLatest commit: 63b8881 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me on behalf of docs!
Make a note of the date: this is the rare time I'm going to wonder whether there is too much in the changeset, compared to the actual change in usage and documentation. 😅
I would be tempted to say that just the line describing the change is enough, without the code snippet. (It's a minor change from existing README documentation, and the examples are clear there on how to type.)
But, I leave the final decision to Platform!
I think I agree with @sarah11918 here. |
Changes
Testing
❌
Docs
❌