Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@astro/cloudflare): improve DX for runtime typing #8560

Merged
merged 6 commits into from
Sep 18, 2023
Merged

feat(@astro/cloudflare): improve DX for runtime typing #8560

merged 6 commits into from
Sep 18, 2023

Conversation

alexanderniebuhr
Copy link
Member

Changes

  • allow users to add env types using a generic, improving DX

Testing

Docs

@alexanderniebuhr alexanderniebuhr requested a review from a team as a code owner September 14, 2023 16:49
@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2023

🦋 Changeset detected

Latest commit: 63b8881

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Sep 14, 2023
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me on behalf of docs!

Make a note of the date: this is the rare time I'm going to wonder whether there is too much in the changeset, compared to the actual change in usage and documentation. 😅

I would be tempted to say that just the line describing the change is enough, without the code snippet. (It's a minor change from existing README documentation, and the examples are clear there on how to type.)

But, I leave the final decision to Platform!

@alexanderniebuhr
Copy link
Member Author

I think I agree with @sarah11918 here.
This is also a patch change, so the smaller changeset should be fine. :)

@ematipico ematipico merged commit 3da5d84 into withastro:main Sep 18, 2023
@astrobot-houston astrobot-houston mentioned this pull request Sep 18, 2023
@alexanderniebuhr alexanderniebuhr deleted the improve-cf-runtime-typing branch September 23, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants