Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change compressHTML default value to true #7918

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

ematipico
Copy link
Member

Changes

Changes the default value of compressHTML to true.

Testing

I updated some tests to reflect the new default.

Docs

/cc @withastro/maintainers-docs for feedback!

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2023

🦋 Changeset detected

Latest commit: 61013c0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 2, 2023
@ematipico ematipico changed the title feat: compressHTML is true default feat: change compressHTML default value to true Aug 2, 2023
@sarah11918
Copy link
Member

sarah11918 commented Aug 2, 2023

If this happens, then we also need to update the types file so that this change is reflected in the docs configuration reference page here! https://docs.astro.build/en/reference/configuration-reference/#compresshtml

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides Sarah's changesets review.

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@ematipico ematipico merged commit 1c076be into next Aug 3, 2023
@ematipico ematipico deleted the feat/compress-html-true branch August 3, 2023 11:19
ematipico added a commit that referenced this pull request Aug 3, 2023
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
ematipico added a commit that referenced this pull request Aug 8, 2023
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants